Skip to content

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6318

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #6319 (c391ab8) into develop (3c770c9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6319      +/-   ##
=============================================
- Coverage      43.12%   43.10%   -0.02%     
- Complexity      8859     8860       +1     
=============================================
  Files           1094     1094              
  Lines          77284    77284              
  Branches       10085    10085              
=============================================
- Hits           33332    33317      -15     
- Misses         39790    39804      +14     
- Partials        4162     4163       +1     

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duhenglucky duhenglucky merged commit 9a7d095 into apache:develop Mar 12, 2023
@duhenglucky duhenglucky added the LTS 4.9.x This PR should cherry picked to LTS branch label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS 4.9.x This PR should cherry picked to LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dledger version to 0.3.1.1
4 participants