Skip to content

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Oct 2, 2025

…meters

Puts "session tracking mode" configuration behind web.xml init parameters. Able to specify if URL tracking mode is removed, added or not manipulated at all. Default is still "remove URL tracking mode" since it aligns with good security practices.
Documentation updates for this PR are here

fixes #2274

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak requested review from bmarwell and fpapon October 2, 2025 23:41
@lprimak lprimak added this to the 2.0.6 milestone Oct 2, 2025
@lprimak lprimak self-assigned this Oct 2, 2025
@lprimak lprimak added java Pull requests that update Java code jakartaee Jakarta EE valid Disable automation for valid issues labels Oct 2, 2025
@lprimak lprimak force-pushed the ee-session-tracking-fix branch from dc0723e to d838762 Compare October 2, 2025 23:48
@lprimak lprimak force-pushed the ee-session-tracking-fix branch from d838762 to f7a2066 Compare October 2, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jakartaee Jakarta EE java Pull requests that update Java code valid Disable automation for valid issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make Session-Tracking-Mode configurable (even with EE integration)
1 participant