[SPARK-45164][PS] Remove deprecated Index APIs
#42926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 14, 2023
zhengruifeng
approved these changes
Sep 14, 2023
dongjoon-hyun
approved these changes
Sep 14, 2023
dongjoon-hyun
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Oh, it seems that there are leftovers.
ERROR [0.054s]: test_is_type_compatible (pyspark.pandas.tests.indexes.test_base.IndexesTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/__w/spark/spark/python/pyspark/pandas/tests/indexes/test_base.py", line 1593, in test_is_type_compatible
self.assert_eq(psidx.is_type_compatible(data_type), expected_result)
File "/__w/spark/spark/python/pyspark/pandas/indexes/base.py", line 2617, in __getattr__
raise AttributeError("'{}' object has no attribute '{}'".format(type(self).__name__, item))
AttributeError: 'Index' object has no attribute 'is_type_compatible'
|
Oh, I missed it. Just cleared the leftovers, thanks! |
dongjoon-hyun
approved these changes
Sep 15, 2023
|
Merged to master. Thank you, @itholic and all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to remove deprecated
IndexAPIs from Pandas API on Spark.Why are the changes needed?
To follow the behavior of the latest Pandas.
See pandas-dev/pandas#37877 for
Index.asi8See pandas-dev/pandas#42113 for
Index.is_type_compatibleDoes this PR introduce any user-facing change?
Index.asi8,Index.is_type_compatibleis removed.Index.astypeandIndex.isincan be used instead respectively.How was this patch tested?
The existing CI should pass.
Was this patch authored or co-authored using generative AI tooling?
No.