[SPARK-48504][PYTHON][CONNECT] Parent Window class for Spark Connect and Spark Classic #46841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jun 3, 2024
| from pyspark.sql.window import Window as PySparkWindow, WindowSpec as PySparkWindowSpec | ||
| from pyspark.errors import PySparkTypeError | ||
|
|
||
| if TYPE_CHECKING: | ||
| from pyspark.sql.connect._typing import ColumnOrName | ||
| from pyspark.sql.connect._typing import ColumnOrName, ColumnOrName_ |
There was a problem hiding this comment.
Why do we need ColumnOrName_?
There was a problem hiding this comment.
This change is to make the typing consistent with classic side, which uses ColumnOrName_.
The ColumnOrName_ was introduced in a70006d
and used in multiple places. Probably we can revisit it and remove it if possible.
HyukjinKwon
approved these changes
Jun 3, 2024
|
Merged to master. |
riyaverm-db
pushed a commit
to riyaverm-db/spark
that referenced
this pull request
Jun 7, 2024
…and Spark Classic ### What changes were proposed in this pull request? Parent Window class for Spark Connect and Spark Classic ### Why are the changes needed? Same as apache#46129 ### Does this PR introduce _any_ user-facing change? Same as apache#46129 ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? NO Closes apache#46841 from zhengruifeng/py_parent_window. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Parent Window class for Spark Connect and Spark Classic
Why are the changes needed?
Same as #46129
Does this PR introduce any user-facing change?
Same as #46129
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
NO