Skip to content

[SPARK-51045][TESTS] Regenerate benchmark results after upgrading to Scala 2.13.16 #49744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 31, 2025

What changes were proposed in this pull request?

This PR aims to regenerate benchmark results of master after upgrading to Scala 2.13.16.

Why are the changes needed?

To check a regression again. Currently, there is only one known benchmark suite failure.

Does this PR introduce any user-facing change?

No, this updates only test results.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title Add Java 17 result [SPARK-51045][TESTS][4.0] Regenerate benchmark results after upgrading to Scala 2.13.16 Jan 31, 2025
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-51045][TESTS][4.0] Regenerate benchmark results after upgrading to Scala 2.13.16 [SPARK-51045][TESTS] Regenerate benchmark results after upgrading to Scala 2.13.16 Jan 31, 2025
@dongjoon-hyun
Copy link
Member Author

Currently, two benchmark failures are detected and I'm looking at them.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review January 31, 2025 08:29
@dongjoon-hyun
Copy link
Member Author

This PR is ready.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR when you have some time, @huaxingao ?

@dongjoon-hyun
Copy link
Member Author

All tests passed.

Screenshot 2025-01-31 at 10 19 20

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @huaxingao !
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the bm_41 branch January 31, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants