[SPARK-51901] [SQL] Disallow generator functions in grouping sets #50698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailoale-db
force-pushed
the
generatorgroupingsets
branch
from
110eea8 to
d561877
Compare
|
@cloud-fan PTAL when you have time. Thanks! |
cloud-fan
reviewed
Apr 28, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
mihailoale-db
force-pushed
the
generatorgroupingsets
branch
from
d561877 to
d262b29
Compare
cloud-fan
reviewed
Apr 28, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
…ysis/Analyzer.scala
|
@cloud-fan passed all the tests! |
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently following query throws an internal error:
I propose that we disallow generator functions in grouping sets and as a consequence throw a more user friendly one.
Why are the changes needed?
To improve error message.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No.