[SPARK-53108][SQL] Implement the time_diff function in Scala #51826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Aug 12, 2025
sql/core/src/test/scala/org/apache/spark/sql/TimeFunctionsSuiteBase.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/TimeFunctionsSuiteBase.scala
Show resolved
Hide resolved
|
@zhengruifeng Please review. |
|
@dongjoon-hyun @LuciferYang Please review. |
|
@cloud-fan Please review. |
cloud-fan
approved these changes
Sep 1, 2025
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement the
time_difffunction in Scala API.Why are the changes needed?
Expand API support for the
TimeDiffexpression.Does this PR introduce any user-facing change?
Yes, the new function is now available in Scala API.
How was this patch tested?
Added appropriate Scala function tests.
Was this patch authored or co-authored using generative AI tooling?
No.