[SPARK-53128][CORE] Include unmanaged memory bytes in the usage log before execution memory OOM #51848
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore execution memory OOM
|
@ericm-db @anishshri-db Would you like to review? Thanks! |
|
@anishshri-db Thank you! |
| "{} bytes of memory are used for execution and {} bytes of memory are used for storage", | ||
| "{} bytes of memory are used for execution " + | ||
| "and {} bytes of memory are used for storage " + | ||
| "and {} bytes of memory are used but unmanaged", |
There was a problem hiding this comment.
Sorry but this might sounds misleading. Can we revise this like the following, @zhztheplayer ?
- and {} bytes of memory are used but unmanaged
+ and {} bytes of unmanaged memory are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have a log before OOM for off-heap memory allocation.
Before the change, the log is:
After:
Why are the changes needed?
Following #51708, to allow user to know the reason if the unmanaged memory causes OOM.
Does this PR introduce any user-facing change?
Only changes a log message.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.