Fix nested char padding #52457
Open
Fix nested char padding #52457
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashdnazg
force-pushed
the
fix-char-pad
branch
from
2653671 to
a37f466
Compare
ashdnazg
force-pushed
the
fix-char-pad
branch
from
a37f466 to
272d0b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix incorrect handling of padding of char fields nested within structs and arrays.
Does this PR introduce any user-facing change?
This fixes comparison of char fields of different lengths nested within structs and within arrays of structs.
How was this patch tested?
Two tests were added which failed before this PR and now pass.
Was this patch authored or co-authored using generative AI tooling?
No