[TOPI] Fix SME conv2d schedule import and intrin argument #17040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a merge conflict between apache#16981 and apache#17003. Change-Id: Ifcc983ef0b8c00250568a048fd682933adfdcde4
Lunderberg
approved these changes
May 29, 2024
There was a problem hiding this comment.
Thank you for the fix!
Looking at the breakage, it looks like it was caused by the addition of a required function parameter in #16981, along with the addition of new calls to that function in #17003. This breakage could have been avoided if the new function parameter had been optional instead of required.
Unless there is a significant reason not to do so, I think new function parameters should be optional, with a default value that reproduces the previous behavior. Doing so would avoid this type of breakage in the future, and would also improve backwards compatibility with external callers, when the function is part of a public-facing API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a merge conflict between #16981 and #17003.
Closes #17038
cc @ekalda @Anndrey24