Skip to content

Introduce outer reduction for metal #17058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

Introduce outer reduction for metal #17058

merged 1 commit into from
Jun 4, 2024

Conversation

Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented Jun 3, 2024

q4f16_0 may improve the performance of metal. To be specific, Llama-3 8B on M1 Pro:

  1. Single batch 26.2 tok/s (q4f16_1) vs. 28.0 tok/s (q4f16_0)
  2. low-batched serving: about 25% improvement

@tqchen tqchen merged commit 1c05902 into apache:main Jun 4, 2024
@ysh329 ysh329 mentioned this pull request Jul 20, 2024
Closed
@kurisu6912 kurisu6912 mentioned this pull request Sep 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hzfengsy @tqchen