Skip to content

[Relay]Disable InferType if it was done and no changes after previous pass #17585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[Relay]Disable InferType if it was done and no changes after previous pass #17585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/relay/ir/dataflow_matcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,24 +851,32 @@ Expr PatternRewriter::Rewrite(const Array<DFPatternCallback>& callbacks, const E
std::unordered_map<DFPatternCallback, bool, ObjectPtrHash, ObjectPtrEqual> done;
do {
last = post;
// We don't have to call InferType if previous pass has not modified anything
// We can just take previous typed state of the expression
bool types_invalidated = true;
for (auto callback : callbacks) {
if (!done[callback]) {
auto before = post;
auto post_typed = post;
callback_ = callback;
if (callback_->require_type) {
post = InferTypeWithModule(post, mod_);
if (callback_->require_type && types_invalidated) {
post_typed = InferTypeWithModule(post, mod_);
}
auto grouper = PatternGrouper();
groups_ = grouper.GroupMatches(callback_->pattern, post);
groups_ = grouper.GroupMatches(callback_->pattern, post_typed);
gid_assignments_ = grouper.GetGIDAssignments();
memo_.clear();
VLOG(1) << "pre rewritten:" << std::endl << PrettyPrint(pre);
post = this->VisitExpr(post);
post = this->VisitExpr(post_typed);
VLOG(1) << "post rewritten:" << std::endl << PrettyPrint(post);
count++;
if (callback_->rewrite_once) {
bool current_equal = (*structural_equal)(before, post, false, true);
if (!current_equal) {
bool current_equal = (*structural_equal)(before, post, false, true);
if (callback_->require_type && current_equal) {
types_invalidated = false;
post = post_typed;
} else {
types_invalidated = true;
if (callback_->rewrite_once) {
done[callback] = true;
}
}
Expand Down
Loading