Skip to content

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Jul 4, 2025

Some changes:

The specifier sequences in many declarations are reordered since:

[[attr]] static inline int a = 0; // OK
static inline int a [[attr]] = 0; // OK

static [[attr]] inline int a = 0; // NOT OK, mixed specifiers
static inline int [[attr]] a = 0; // NOT OK, attr is applied to the type

Reviewers can focus on ffi/include/tvm/ffi/base_details.h to avoid being overwhelmed by many trivial changes : )

@PragmaTwice PragmaTwice marked this pull request as ready for review July 4, 2025 11:20
@Hzfengsy
Copy link
Member

Hzfengsy commented Jul 4, 2025

cc @tqchen

@tqchen tqchen merged commit a4dc883 into apache:main Jul 4, 2025
15 checks passed
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
)

[FFI] Replace __attribute__ with C++ standard attributes
tqchen pushed a commit to tqchen/tvm that referenced this pull request Sep 13, 2025
)

[FFI] Replace __attribute__ with C++ standard attributes
tqchen pushed a commit to tqchen/tvm that referenced this pull request Sep 13, 2025
)

[FFI] Replace __attribute__ with C++ standard attributes
tqchen pushed a commit to tqchen/tvm that referenced this pull request Sep 13, 2025
)

[FFI] Replace __attribute__ with C++ standard attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants