[FFI] Replace __attribute__
with C++ standard attributes
#18114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes:
__attribute__((unused))
is replaced by C++ standard attribute[[maybe_unused]]
(https://en.cppreference.com/w/cpp/language/attributes/maybe_unused.html)__forceinline
is replaced by[[msvc::forceinline]]
(MSVC: https://learn.microsoft.com/en-us/cpp/cpp/attributes?view=msvc-170#msvcforceinline, NOTE thatinline
is added which is a slight difference with__forceinline
)__attribute__((always_inline))
is replaced by[[gnu::always_inline]]
(Clang: https://clang.llvm.org/docs/AttributeReference.html#always-inline-force-inline, GCC: https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html)__declspec(noinline)
is replaced by[[msvc::noinline]]
(MSVC: https://learn.microsoft.com/en-us/cpp/cpp/attributes?view=msvc-170#msvcnoinline)__attribute__((noinline))
is replaced by[[gnu::noinline]]
(Clang: https://clang.llvm.org/docs/AttributeReference.html#noinline, GCC: https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html)The specifier sequences in many declarations are reordered since:
Reviewers can focus on
ffi/include/tvm/ffi/base_details.h
to avoid being overwhelmed by many trivial changes : )