Skip to content

ZOOKEEPER-4934: Add metrics for TTL node creation #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ZOOKEEPER-4934: Add metrics for TTL node creation #2287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee132fb
ZOOKEEPER-4934: Add metrics for TTL node creation
ivandika3 Jul 31, 2025
bc0937f
Trigger CI
ivandika3 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ public void createNode(final String path, byte[] data, List<ACL> acl, long ephem
containers.add(path);
} else if (ephemeralType == EphemeralType.TTL) {
ttls.add(path);
ServerMetrics.getMetrics().TTL_NODE_CREATED_COUNT.add(1);
} else if (ephemeralOwner != 0) {
HashSet<String> list = ephemerals.computeIfAbsent(ephemeralOwner, k -> new HashSet<>());
synchronized (list) {
Expand Down
4 changes: 3 additions & 1 deletion zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ private ServerMetrics(MetricsProvider metricsProvider) {
QUOTA_EXCEEDED_ERROR_PER_NAMESPACE = metricsContext.getCounterSet(QuotaMetricsUtils.QUOTA_EXCEEDED_ERROR_PER_NAMESPACE);

TTL_NODE_DELETED_COUNT = metricsContext.getCounter("ttl_node_deleted_count");
TTL_NODE_CREATED_COUNT = metricsContext.getCounter("ttl_node_created_count");
}

/**
Expand Down Expand Up @@ -550,9 +551,10 @@ private ServerMetrics(MetricsProvider metricsProvider) {
public final CounterSet QUOTA_EXCEEDED_ERROR_PER_NAMESPACE;

/**
* Count of deleted TTL nodes
* Count of created and deleted TTL nodes
*/
public final Counter TTL_NODE_DELETED_COUNT;
public final Counter TTL_NODE_CREATED_COUNT;

private final MetricsProvider metricsProvider;

Expand Down
3 changes: 2 additions & 1 deletion zookeeper-server/src/test/java/org/apache/zookeeper/server/CreateTTLTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ public void testCreate() throws KeeperException, InterruptedException {
containerManager.checkContainers();
assertNull(zk.exists("/foo", false), "Ttl node should have been deleted");

// validate deleted TTL nodes count
// validate created and deleted TTL nodes count
Map<String, Object> metrics = MetricsUtils.currentServerMetrics();
assertTrue((long) metrics.get("ttl_node_created_count") >= 1);
assertTrue((long) metrics.get("ttl_node_deleted_count") >= 1);
}

Expand Down