ZOOKEEPER-4963: Add ZooKeeper::builder to replace new ZooKeeperBuilder
#2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be superceded by #2308 if we are going that way. |
…lder` `ZooKeeper::builder` should be better: 1. More exposure chance as a newly introduce method in class `ZooKeeper`. 2. No need to import or remember the newly introduced class as most `ZooKeeper` instances could be built in one chain. `ZooKeeperBuilder` is introduced in 3.10.0 so it safe to do this. Refs: ZOOKEEPER-4697
kezhuw
force-pushed
the
ZOOKEEPER-4963-ZooKeeper_builder
branch
from
c55021f to
90ec94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZooKeeper::buildershould be better:ZooKeeper.ZooKeeperinstances could be built in one chain.ZooKeeperBuilderis introduced in 3.10.0 so it safe to do this.Refs: ZOOKEEPER-4697