Swagger Look Messy with Subresource

[bitcoinporn]

I working with sub resources, and now swagger page look very messy.

Subresource should not appear on target groups. Any setting to prevent this?

[soyuka]

Looks fine 😆

[bitcoinporn]

also consider to add depth settings.
I found we can have same naming on sub resource

[soyuka]

I'd like a case reproduction for name collision if you have one!

[bitcoinporn]

sorry typo...
i mean we can't have same sub resource name.
example:
i have 2 entities, that 2 entities have "likes" sub resources.
/contents/{id}/likes
/events/{id/likes

when i want to make both as "user" sub resources, its not allowed.
/users/{id}/events/{id}/likes
/users/{id}/contents/{id}/likes

we should allow this practices.

[bitcoinporn]

@soyuka : do you have suggestion for quick fix for this?

[soyuka]

@synchr0n123r this look like a bug, I need to take a closer look.

[soyuka]

@synchr0n123r I don't get it, this should be good. All you have to do is add a Subresource on Events and Contents in the User entity.

See the referenced commit, that's exactly what the test is trying to do and I'm getting the correct results.

Please give me a reproduction case in a gist if you can.

[soyuka]

Any updates?

[Nightbr]

Hey same issue here, I think it should be nice to control the depth of subresources.

For example, If I have /api/publications/{id}/comments and /api/users/{id}/publications, I don't want to generate the route /api/users/{id}/publications/{publications}/likes.

I tried by adding @MaxDepth(1) annotation but no effect (I'm pretty sure it's because MaxDepth is related to the serializer and not the route generator but I give it a try ^^)

Thanks!

[soyuka]

I tried by adding @maxdepth(1) annotation but no effect (I'm pretty sure it's because MaxDepth is related to the serializer and not the route generator but I give it a try ^^)

No you're right. Should be pretty easy to implement in

core/src/Operation/Factory/SubresourceOperationFactory.php

Line 64 in 091865f

private function computeSubresourceOperations(string $resourceClass, array &$tree, string $rootResourceClass = null, array $parentOperation = null, array $visited = [])

Feel free to PR on this :).

[Nightbr]

@soyuka sure I am on it with also a bug with normalization_context with subresources:
api-platform/api-platform#440

[Nightbr]

I think we should close this with the PR merged!