3.3.10 [BC break?]: Entities with embedded non-resource subentities fail schema checks after #6366

[paullallier]

API Platform version(s) affected: 3.3.10, specifically #6366 I think

Description
Upgrading to 3.3.10 breaks schema checks on entities with embedded subentities (especially one with genId: false set).

How to reproduce
I have a lot of instances where I'm using #[ApiProperty(genId: false)] to include an array of subentities inside another entity - where I don't want the user to be able to extract the subentities on there own (and there's no endpoint to do so). For example:

class Tax
{
    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\Column]
    #[Groups(['tax:read', 'tax:id_only', 'account:read_collection', 'account:read_item'])]
    private ?int $id = null; // Returns value from numberId on the API

    #[ORM\Column(length: 128)]
    #[Groups(['tax:read', 'tax:write', 'account:read_collection', 'account:read_item'])]
    private ?string $description = null;

<snip>

    #[ORM\OneToMany(mappedBy: 'componentOf', targetEntity: TaxComponent::class)]
    #[Groups(['tax:read', 'tax:write'])]
    #[ApiProperty(genId: false)]
    protected ?Collection $components;

Which give a failure like this when I 'GET' an entity and check it with self::assertMatchesResourceItemJsonSchema():

Failed asserting that Array &0 (
    '@context' => '/contexts/Tax'
    '@id' => '/taxes/1622'
    '@type' => 'Tax'
    'id' => 1622
    'description' => 'Consectetur hic optio.'
    'components' => Array &2 (
        0 => Array &3 (
            '@type' => 'TaxComponent'
            'name' => 'Fugit quam sed atque.'
            'ratePercent' => '43.2000'
            'priority' => 7
            'account' => '/accounts/113'
        )
    )
) matches the provided JSON Schema.
components[0].@context: The property @context is required
components[0].@id: The property @id is required

Question 1:
While I don't doubt the this statement from the PR is correct:
"This PR modifies SchemaFactory for JSON-LD to output JSON-LD specific properties such as @context @id @type as REQUIRED."
Is it compatible with #[ApiProperty(genId: false)]?

I can't get the test harness to run for me at the moment, so I can't easily test it, but would the tests involving this entity pass the requirement to have @id and @context on the "notResourceObjects" embedded it it, if those test checked the schema more completely?
tests/Fixtures/TestBundle/ApiResource/DummyWithArrayOfNotResourceObjects.php

Question 2:
I'm not sure why I'm not getting a @context on my components. That might be an issue with my code rather than API-P. My provider returns a Tax object with an array of TaxComponent objects in it - and the above is how it gets output on the API.

[soyuka]

@id and @type are definitely required fields on a json-ld output, @context though may not be inside embedded resources I'll revert this for now and we need to see how to add this to 3.4 properly.

[paullallier]

Thanks @soyuka.

[paullallier]

Passes now - thanks.