-
-
Notifications
You must be signed in to change notification settings - Fork 908
Use serialized_name in Swagger UI Links section #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18935e9
to
addd778
Compare
Thanks for your help @dunglas, could you check again if this is the right way please? |
This looks good to me! Can you also add some tests please? |
@dunglas I added a test, but I found a problem in OperationPathResolver.php explained in this comment So I think we can use this pull request to fix the custom serialized name error, and then create another issue to fix the hardcoded {id} parameter in the paths. What do you think? |
@dunglas I took the URI parameter name in Swagger UI Links section from the URI itself, so it should match the identifier property name in almost all cases. I took the last parameter in the URI, so it will work on subresources too. I also added another assertion to test serialized name loading from Serializer attributes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Show custom serialized_name if set from Resource attributes in Swagger UI Links section instead original Resource property.