Skip to content

Conversation

ersin-demirtas
Copy link
Contributor

No feature or bug fixes only moving away from TravisCI to Github actions. Halfway there requires code review.

@ersin-demirtas
Copy link
Contributor Author

I will do some tests tomorrow to make sure its working.

@ersin-demirtas ersin-demirtas changed the title removed .travis.yml and added github actions [WIP] removed .travis.yml and added github actions Jan 26, 2021
@ersin-demirtas ersin-demirtas changed the title [WIP] removed .travis.yml and added github actions Removed .travis.yml and added github actions Feb 12, 2021
@ersin-demirtas
Copy link
Contributor Author

ersin-demirtas commented Feb 12, 2021

@dunglas Ready for CR, I made some tests with npm publish and worked as expected. A new secret key value needs to be added to NPM_TOKEN secret needs to be added GitHub secrets.

Example actions result:
https://github.com/ersin-demirtas/client-generator/runs/1887608739

I will remove this package after the PR close.

@dunglas dunglas merged commit 8b60676 into api-platform:main Mar 11, 2021
@dunglas
Copy link
Member

dunglas commented Mar 11, 2021

Thank you very much @ersin-demirtas!

justinezahiri pushed a commit to justinezahiri/api-platform-client-generator that referenced this pull request Aug 5, 2021
* removed .travis.yml and added github actions

* Added new line to end of file

* moved npm publish to its own yml file to execute on release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants