Skip to content

Conversation

ginifizz
Copy link
Contributor

@ginifizz ginifizz commented Nov 4, 2022

! Needs to be merged at the same time as #2320

<a className="text-sm text-cyan-500 font-bold hover:text-cyan-700">
{`< Back to list`}
</a>
</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Bad indentation

/>
<ErrorMessage
className="invalid-feedback"
className="text-xs text-red-500 pt-1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="text-xs text-red-500 pt-1"
className="text-xs text-red-500 pt-1"

export const List: FunctionComponent<Props> = ({ {{{lc}}}s }) => (
<div>
<h1>{{{ucf}}} List</h1>
<div className="p-4">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="p-4">
<div className="p-4">

@dunglas
Copy link
Member

dunglas commented Nov 15, 2022

The test failure looks related. Do you have an idea of what's going on @alanpoulain?

@alanpoulain
Copy link
Member

It's probably because create-next-app does not generate pages/index.tsx anymore. It needs to be investigated.

@alanpoulain alanpoulain force-pushed the feat/update-style branch 2 times, most recently from 3050f03 to 4d62e80 Compare December 2, 2022 16:08
@alanpoulain alanpoulain merged commit e405014 into api-platform:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants