fix: silence useLayoutEffect warning when useSuspenseQuery runs on server #10399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 567370f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jerelmiller
approved these changes
Jan 3, 2023
|
Before/after screenshots of demo server logs (warning is no longer present):
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10361.
Uses existing
canUseLayoutEffectutility in auseIsomorphicLayoutEffectutil which falls back touseEffecton the server to silence the warning reported in #10361. (Using a noop instead ofuseEffectcaused test failures even thoughuseEffectdoes nothing in SSR.)This is a stop-gap until
useSuspenseQuerySSR support is built out, but a general-purposeuseIsomorphicLayoutEffectwill probably come in handy in the future so I opted to open this PR.