-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Restore Apollo Client 3.7 getApolloContext
behaviour
#11082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a34050e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you found this before release! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This was triggered over in reduxjs/react-redux#2053
TLDR: AliPay mini widgets deliberately remove anything that is global in their runtime: window, self, global, globalThis, you name it, it's gone.
This doesn't impact the globalThis.DEV, as that can be removed by a compiler, but it does impact situations where we attempt to write to globalThis - so I am rolling back this change to the 3.8 behaviour.. (for reference, see https://github.com/apollographql/apollo-client/blob/27fbdb3f9003cc304d26987cb38daf10910f2da6/src/react/context/ApolloContext.ts )
Checklist: