✅ Validation: allow nullable variables in non-null locations if there is a default value #3879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
requested review from
sav007,
tasomaniac and
BoD
as code owners
martinbonnin
commented
Feb 17, 2022
| is GQLNonNullType -> type.canInputValueBeAssignedTo(target.type) | ||
| is GQLListType -> type.canInputValueBeAssignedTo(target) | ||
| is GQLNamedType -> type.canInputValueBeAssignedTo(target) | ||
| internal fun isVariableUsageAllowed(variableDefinition: GQLVariableDefinition, usage: VariableUsage): Boolean { |
There was a problem hiding this comment.
This is a lot of shuffling around to match better with the spec terminology and algorithm
martinbonnin
commented
Feb 17, 2022
|
|
||
| if (locationType is GQLNonNullType && variableType !is GQLNonNullType) { | ||
| if (variableDefinition.defaultValue == null && !usage.hasLocationDefaultValue) { | ||
| return false |
There was a problem hiding this comment.
This is the actual fix
martinbonnin
deleted the
allow-nullable-variables-in-nonnull-locations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement http://spec.graphql.org/draft/#sec-All-Variable-Usages-are-Allowed.Allowing-optional-variables-when-default-values-exist
Closes #3227
See #3878