Skip to content

Allow to shutdown SchemaDownloader #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

martinbonnin
Copy link
Contributor

This is important for tools like CLI that otherwise stay stuck until the threadpool terminates

@martinbonnin martinbonnin requested a review from BoD as a code owner August 2, 2024 15:31
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit a4614c9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66acfc02438b640008fae78a

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 39a2669 into main Aug 2, 2024
9 checks passed
@martinbonnin martinbonnin deleted the expose-schema-downloader-shutdown branch August 2, 2024 15:52
@martinbonnin martinbonnin added this to the 4.0.1 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants