Extended types are ignored

[Baloche]

Hello 👋

My schema :

type Query {
  games: [Game]!
}

type Game {
  id: ID!
  name: String!
}

extend type Game {
  playersCount: Int!
}

My query :

const query = gql`
  query games {
    games {
      id
      name
      playersCount
  }
`

The warning I get :

Cannot query field "playersCount" on type "Game". eslint(graphql/template-strings)

Extended types are not supported by the plugin or am I doing something wrong ?

[jnwng]

it'd be useful to get more information about the schema you're using — if you wouldn't mind, can you share the actual JSON representation of the schema that you started with?

it'd also be useful to see how you're configuring this plugin in your .eslintrc to figure out whether the extend type is showing up in the schema to begin with.

[Baloche]

I'm sorry, I don't get which informations you need. This is my entire schema defined in a schema.graphql file.

Here is my .eslintrc.js where schemaString is my entire schema as a string :

module.exports = {
  extends: ['plugin:react/recommended'],
  plugins: ['graphql'],
  rules: {
    'graphql/template-strings': ['error', { env: 'apollo', schemaString }],
    'graphql/required-fields': ['error', { env: 'apollo', schemaString, requiredFields: ['id'] }],
  },
}

I don't have myself a JSON representation of the schema.

[jnwng]

can you share the schemaString? or is it directly the SDL you shared already?

…

On Thu, May 16, 2019 at 5:54 AM Valentin Bailleul ***@***.***> wrote: I'm sorry, I don't get which informations you need. This is my entire schema defined in a schema.graphql file. Here is my .eslintrc.js where schemaString is my entire schema as a string : module.exports = { extends: ['plugin:react/recommended'], plugins: ['graphql'], rules: { 'graphql/template-strings': ['error', { env: 'apollo', schemaString }], 'graphql/required-fields': ['error', { env: 'apollo', schemaString, requiredFields: ['id'] }], }, } I don't have myself a JSON representation of the schema. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#227?email_source=notifications&email_token=AAIRCRVNH246NIBDYVTYZ6LPVVKQTA5CNFSM4HNC55K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRW3HA#issuecomment-493055388>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIRCRWRT4V7SFI3GAXRBLLPVVKQTANCNFSM4HNC55KQ> .

[Baloche]

Yes, schemaString is the schema I already shared, in SDL, as a string.

[jnwng]

this took me down a huge rabbit hole and i found an answer.

under the hood, eslint-plugin-graphql is just delegating to graphql-js to handle schema parsing, we just provide a few options of how you pass that schema to validated your graphql documents. in this case, with the schemaString option, we call buildSchema from the graphql package, which in turn calls buildASTSchema internally, which led me to this open issue on supporting extend within the buildASTSchema, which looks like it's slated for release in graphql@15.0.0 (we dont have support for that version just yet)

however, afaik, graphql-tools already supports creating schemas with the extend keyword, so if you create the schema using graphql-tools, you can send it via the schemaJson option and this should all lint properly.

i hope this helps!