Skip to content

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Nov 4, 2022

Change list

Currently our 'env.json.sample' contains the 'dev' property as Lowercase while our code is looking for 'DEV' in uppercase.

https://github.com/appium/appium-dotnet-driver/blob/6434b152860a2cf3ff52e41b3c6522ebe31db646/test/integration/helpers/Env.cs#L47-L51

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@github-actions github-actions bot added the BugFix label Nov 4, 2022
@Dor-bl Dor-bl changed the title fix: dev property should be in uppercase fix: dev property should be in uppercase inside the env.json.sample file Nov 4, 2022
@KazuCocoa
Copy link
Member

Maybe you can already merge, correct? @Dor-bl You are in this repository's collaborator, in the settings

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 5, 2022

@KazuCocoa Yes I am :)
I'll do it myself.(1st merge)
Thanks for the approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants