Skip to content

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Nov 6, 2022

Change list

touch Actions are no longer supported on selenium v4
users should use the W3C actions: http://appium.io/docs/en/commands/interactions/actions/
related to: appium/appium#16009

** Since this deprecation is going to version 5.0, I haven't saw a point in adding obsolete messages and keeping them for another release

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@KazuCocoa
Copy link
Member

Can we raise deprecation warnings rather than removing them as the initial v5 release?
Other clients also currently show deprecation warnings (or show the warning in their documentation).
e.g. https://github.com/appium/python-client/blob/4c166f45516a432ec807195f91fc2f208a3a3c08/appium/webdriver/common/multi_action.py#L33

Appium still can accept them (but they will be removed eventually). As clients, it would be nice to remove deprecated methods after showing warnings about them

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 6, 2022

Can we raise deprecation warnings rather than removing them as the initial v5 release? Other clients also currently show deprecation warnings (or show the warning in their documentation). e.g. https://github.com/appium/python-client/blob/4c166f45516a432ec807195f91fc2f208a3a3c08/appium/webdriver/common/multi_action.py#L33

Appium still can accept them (but they will be removed eventually). As clients, it would be nice to remove deprecated methods after showing warnings about them

ok. will do

Revert "chore: add deprecations for TouchAction and MultiAction"

This reverts commit 13c9383.
@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 7, 2022

@KazuCocoa @akinsolb, I have minor thing to change. please wait with the Review

@Dor-bl
Copy link
Collaborator Author

Dor-bl commented Nov 7, 2022

@KazuCocoa @akinsolb feel free to review. I'm done with the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants