Skip to content

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Jan 5, 2023

Change list

following commit 6294052 , AppTests can't pass since IntentApp was removed.
I made some adjustments and cleaned the obsolete strings

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@Dor-bl Dor-bl added the Test label Jan 5, 2023
@Dor-bl Dor-bl requested a review from laolubenson January 8, 2023 19:09
@Dor-bl Dor-bl mentioned this pull request Jan 8, 2023
6 tasks
@laolubenson laolubenson merged commit 5601eb5 into appium:release/5.0.0 Jan 8, 2023
agentran added a commit to agentran/dotnet-client that referenced this pull request Jan 10, 2023
Dor-bl pushed a commit that referenced this pull request Feb 12, 2023
* Revert "Revert "activate app with timeout""

This reverts commit 893d0e1.

* do not revert #576
@Dor-bl Dor-bl deleted the appTests branch April 25, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants