Skip to content

Add lock_test.py #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

VenkateshPS
Copy link
Contributor

@VenkateshPS VenkateshPS commented Dec 8, 2018

Add unit test for lock library

#283

Add unit for lock library
@jsf-clabot
Copy link

jsf-clabot commented Dec 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ VenkateshPS
❌ Venkatesh Singh


Venkatesh Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@KazuCocoa
Copy link
Member

  • Could you add a link to Add unit tests #283 in the description if this PR is related to that?
  • Could you fix the CI first?

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete test/unit/webdriver/device/lock_test.py in 2b40605 and commit the test code in the root path? test/unit/webdriver/device/lock_test.py is better.

@KazuCocoa
Copy link
Member

the code looks fine, but could you fix the CLA?
You have two commit which has different email addresses, I assume.

@VenkateshPS
Copy link
Contributor Author

unable to resolve commits by different email id, will create a new pull request.

@VenkateshPS VenkateshPS deleted the VenkateshPS-patch-1 branch December 10, 2018 19:38
@KazuCocoa
Copy link
Member

KazuCocoa commented Dec 11, 2018

you probably can fix it with git rebase or sign the CLA with your another email though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants