-
Notifications
You must be signed in to change notification settings - Fork 567
Add network unittest #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add network unittest #308
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f3f85dc
Add network connection test
ki4070ma 626f1ae
Added set network connection test
ki4070ma eb089ba
Add toggle wifi test
ki4070ma 95e4550
Removed unnecessary codes from toggle wifi test
ki4070ma 3d4487d
Changed assertion for set network connection test
ki4070ma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
#!/usr/bin/env python | ||
|
||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from appium.webdriver.webdriver import WebDriver | ||
from test.unit.helper.test_helper import appium_command, android_w3c_driver | ||
|
||
import httpretty | ||
|
||
|
||
class TestWebDriverNetwork(object): | ||
|
||
@httpretty.activate | ||
def test_network_connection(self): | ||
driver = android_w3c_driver() | ||
httpretty.register_uri( | ||
httpretty.GET, | ||
appium_command('/session/1234567890/network_connection'), | ||
body='{"value": 2}' | ||
) | ||
assert driver.network_connection == 2 | ||
|
||
@httpretty.activate | ||
def test_set_network_connection(self): | ||
driver = android_w3c_driver() | ||
httpretty.register_uri( | ||
httpretty.POST, | ||
appium_command('/session/1234567890/network_connection'), | ||
body='{"value": 2}' | ||
) | ||
assert driver.set_network_connection(2) == 2 | ||
|
||
@httpretty.activate | ||
def test_toggle_wifi(self): | ||
driver = android_w3c_driver() | ||
httpretty.register_uri( | ||
httpretty.POST, | ||
appium_command('/session/1234567890/appium/device/toggle_wifi'), | ||
) | ||
assert isinstance(driver.toggle_wifi(), WebDriver) is True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add assertions for the request body like below?
https://github.com/appium/python-client/blob/master/test/unit/webdriver/device/clipboard_test.py
The return value is enough to
""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review.
Done by 3d4487d