[ExecuTorch] Support Several Indexing Ops #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2024 11:15
…an example to make it clearer
…improve index_put; polish copy and reshape ops along the way
YifanShenSZ
requested review from
jakesabathia2,
TobyRoseman,
aseemw,
junpeiz and
DawerG
TobyRoseman
previously approved these changes
Apr 8, 2024
jakesabathia2
requested changes
Apr 8, 2024
coremltools/converters/mil/mil/ops/defs/iOS15/scatter_gather.py
Outdated
Show resolved
Hide resolved
added 2 commits
April 8, 2024 17:28
…fferent shapes; make doc more explicit
…rror messages and docs, mostly by adding examples
jakesabathia2
previously approved these changes
Apr 9, 2024
jakesabathia2
approved these changes
Apr 10, 2024
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Apr 11, 2024
Summary: It was a workaround to skip `aten.index_put` op in Core ML delegation, at the cost of partitioning the Llama model into 13 pieces. For better performance, we prefer to delegate the whole model to Core ML. Since Core ML has added the [necessary support](apple/coremltools#2190), it is time to revert this workaround Pull Request resolved: #2975 Reviewed By: kirklandsign Differential Revision: D56002979 Pulled By: cccclai fbshipit-source-id: e7a7c8c43706cb57eba3e6f720b3d713bec5065b
pytorchbot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Apr 19, 2024
Summary: It was a workaround to skip `aten.index_put` op in Core ML delegation, at the cost of partitioning the Llama model into 13 pieces. For better performance, we prefer to delegate the whole model to Core ML. Since Core ML has added the [necessary support](apple/coremltools#2190), it is time to revert this workaround Pull Request resolved: #2975 Reviewed By: kirklandsign Differential Revision: D56002979 Pulled By: cccclai fbshipit-source-id: e7a7c8c43706cb57eba3e6f720b3d713bec5065b (cherry picked from commit 7d4bafc)
guangy10
pushed a commit
to pytorch/executorch
that referenced
this pull request
Apr 19, 2024
#3157) Summary: It was a workaround to skip `aten.index_put` op in Core ML delegation, at the cost of partitioning the Llama model into 13 pieces. For better performance, we prefer to delegate the whole model to Core ML. Since Core ML has added the [necessary support](apple/coremltools#2190), it is time to revert this workaround Pull Request resolved: #2975 Reviewed By: kirklandsign Differential Revision: D56002979 Pulled By: cccclai fbshipit-source-id: e7a7c8c43706cb57eba3e6f720b3d713bec5065b (cherry picked from commit 7d4bafc) Co-authored-by: yifan_shen3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for torch.select_scatter and torch.slice_scatter, polish existing support for torch.index_put_
Polish existing support for torch.copy_ and torch.view along the way
Testing:
frontend=TorchFrontend.EXIR