Need fstream to compile on Mac

[panghy]

Perhaps you guys have a different setup, but I needed to make the following changes to compile on my Mac:

===================================================================
--- fdbserver/fdbserver.actor.cpp             (revision f069fdf042094deecfdc65a31c6f4e8b03f0a81b)
+++ fdbserver/fdbserver.actor.cpp          (revision bff15c68afe6a370436091e654e4bcd8a24728c0)
@@ -36,6 +36,7 @@
#include "DataDistribution.h"
#include "NetworkTest.h"
#include "IKeyValueStore.h"
+#include <fstream>
#include <stdarg.h>
#include <stdio.h>
#include "pubsub.h"

[alecgrieser]

Interesting. I was able to run a macOS build on my laptop without issue. It's possible that the thing to do is for us to just add this dependency because I don't think it would cause any harm and might get you and/or others in your same situation unstuck. Here's our compiler invocation command that is compiling fdbserver.actor.g.cpp:

/usr/bin/clang -Werror -Wno-error=format -fPIC -DNO_INTELLISENSE -fvisibility=hidden -DNDEBUG=1 -Wreturn-type -fno-omit-frame-pointer -mmacosx-version-min=10.7 -stdlib=libc++ -O2 -g -mmacosx-version-min=10.7 -std=c++11 -stdlib=libc++ -msse4.2 -Wno-undefined-var-template -Wno-unknown-warning-option -Wno-deprecated -I/Volumes/HomeData/Users/alec/boost_1_52_0 -I. -Ifdbrpc -Ifdbrpc/libeio -DUSE_UCONTEXT -fasynchronous-unwind-tables -fno-omit-frame-pointer  -MMD -MT .objs/fdbserver/fdbserver.actor.g.cpp.o -MF .deps/fdbserver/fdbserver.actor.g.cpp.d.tmp -c fdbserver/fdbserver.actor.g.cpp -o .objs/fdbserver/fdbserver.actor.g.cpp.o

Not sure if that helps or not. It could be a clang version difference, I suppose, if you are using a different clang version than we are.

[alecgrieser]

And by dependency, I mean include.

[panghy]

Hm, High Sierra 10.13.3 here. Just doing make without docker.

[alecgrieser]

Could you submit a PR with the extra include into the release-5.1 branch and tag it with this issue? We'll take a look and merge it in.

[panghy]

Seems like I no longer need the patch for it to build. Not sure why. Closing for now.