Swift 6 preparations #50
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds actor isolation to
withEvaluatorManager
as done by other APIs like AsyncHTTPClient. This is explained in detail in this talk, and is part of SE-0461 where it will be the default.I noticed this when I tried to call this function from the library I am working on. As the above SE proposal says, it's easy to miss:
The PR also includes a change in the swift codegen types so that they are marked
Sendable
, andPklSwift
is imported with@preconcurrency
.In addition, marked some basic types
Sendable
:Duration
DurationUnit
ModuleSource
PklEvaluatorSettings
PklEvaluatorSettingsColor
Http
Proxy
ExternalReader
, andPathElement