Skip to content

Conversation

natecook1000
Copy link
Member

Some minor NFC changes to resolve strict concurrency checking warnings/errors and the warning about the change in meaning for #file.

Some minor NFC changes to resolve strict concurrency checking
warnings/errors and the warning about the change in meaning for
`#file`.
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 requested a review from rauhul June 28, 2024 17:33
Copy link
Contributor

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand the file -> filePath change but looks right overall

@@ -10,7 +10,11 @@
//===----------------------------------------------------------------------===//

import Foundation
#if swift(>=6)
@preconcurrency import PackagePlugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it feels like we should file a bug on SwiftPM for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the warnings that led me to add this anymore 😭

@natecook1000 natecook1000 enabled auto-merge (squash) July 15, 2024 21:07
@natecook1000
Copy link
Member Author

@swift-ci Please test

@natecook1000 natecook1000 merged commit bb10ca8 into main Jul 15, 2024
@natecook1000 natecook1000 deleted the swift6-support branch July 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants