Skip to content

Escape single quotes in shellCommand completions for fish #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Escape single quotes in shellCommand completions for fish #811

merged 1 commit into from
Sep 19, 2025

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Sep 14, 2025 •
edited
Loading

Escape single quotes in shellCommand completions for fish.

Resolve #810

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

natecook1000
natecook1000 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rgoldberg!

@rgoldberg
Copy link
Contributor Author

@natecook1000 Glad to submit. Thanks for all the help.

@natecook1000 natecook1000 merged commit 04695ec into apple:main Sep 19, 2025
31 checks passed
@rgoldberg rgoldberg deleted the 810-fish-shellCommand branch September 19, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natecook1000 natecook1000 natecook1000 approved these changes

@rauhul rauhul Awaiting requested review from rauhul rauhul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must escape single quotes in fish shellCommand completions
2 participants
@rgoldberg @natecook1000