Skip to content

Can't follow advice to use soundness script when submitting a patch #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heckj opened this issue Apr 15, 2025 · 0 comments · Fixed by #97
Closed

Can't follow advice to use soundness script when submitting a patch #96

heckj opened this issue Apr 15, 2025 · 0 comments · Fixed by #97

Comments

@heckj
Copy link
Collaborator

heckj commented Apr 15, 2025

(for this project at comit 328ef68)

The CONTRIBUTING.md file suggests running a soundness script that looks like it's been deleted in favor of using the GitHub action swiftlang/github-workflows/.github/workflows/soundness.yml. I believe the advice in CONTRIBUTING should probably be removed now that this is in place.

euanh added a commit to euanh/swift-sdk-generator that referenced this issue Apr 16, 2025
Utilities/soundness.sh was deleted in swiftlang#199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
euanh added a commit to euanh/swift-sdk-generator that referenced this issue Apr 16, 2025
Utilities/soundness.sh was deleted in swiftlang#199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
euanh added a commit to euanh/swift-openapi-generator that referenced this issue Apr 16, 2025
scripts/soundness.sh was deleted in apple#604 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
@euanh euanh closed this as completed in #97 Apr 16, 2025
@euanh euanh closed this as completed in 7229c3a Apr 16, 2025
MaxDesiatov pushed a commit to swiftlang/swift-sdk-generator that referenced this issue Apr 16, 2025
Utilities/soundness.sh was deleted in #199 which moved CI to GitHub Actions.

Credit to @heckj, who found the same problem in apple/swift-container-plugin#96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant