Skip to content

Conversation

compnerd
Copy link
Contributor

This adds Windows to the SystemNumberGenerator condition as well, which
is needed to get the tests to build on Windows.

[One line description of your change]

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

This adds Windows to the SystemNumberGenerator condition as well, which
is needed to get the tests to build on Windows.
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm I’ve audited the Swift code, and that the Windows implementation of SystemRandomNumberGenerator is suitable for use as a CSPRNG.

@Lukasa Lukasa merged commit 85d00fe into apple:main Jan 22, 2021
@compnerd compnerd deleted the rng branch February 6, 2021 17:52
rnro pushed a commit to rnro/swift-crypto that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants