Remove use of getImplicitlyUnwrappedOptionalDecl.

[rudkx]

As of swiftlang/swift#14299, we should effectively
no longer see this decl since we no longer generate IUO types.

A follow-on PR actually removes this API completely:
swiftlang/swift#14364

[rudkx]

@swift-ci Please test

[vedantk]

@rudkx I alluded to this in swiftlang/swift#14364, but you may need to ask @shahmishal to force-merge this due to preexisting test failures on the branch.

The lldb smoke tests should be in good health, however. If you'd like to run those tests locally, use this command:

./swift/utils/build-script --release --skip-build-benchmarks --skip-test-cmark --skip-test-swift --lldb --lldb-use-system-debugserver --lldb-build-with-cmake --test --lldb-test-swift-only

It should run a lot faster than the full lldb test suite.

[rudkx]

Okay, I tried that and hit this. We shouldn't be assuming ninja is in the path. Other parts of the build ensure that ninja is built if it isn't already in the path, and then use the built one.

[[EDIT]] Really we should just be consistent here, we should either require ninja in the path everywhere, or nowhere.

Linking /Users/mark_lacey/swift-project/build/ra/swiftpm-macosx-x86_64/x86_64-apple-macosx10.10/debug/SwiftPMPackageTests.xctest/Contents/MacOS/SwiftPMPackageTests
+ pushd /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64
~/swift-project/build/ra/lldb-macosx-x86_64 ~/swift-project/swift
+ ninja check-lldb-unit
/Users/mark_lacey/swift-project/swift/utils/build-script-impl: line 284: ninja: command not found

After manually adding it to the path, I hit this:

env SWIFTCC=/Users/mark_lacey/swift-project/build/ra/swift-macosx-x86_64/bin/swiftc SWIFTLIBS=/Users/mark_lacey/swift-project/build/ra/swift-macosx-x86_64/lib/swift /Users/mark_lacey/swift-project/lldb/test/dotest.py --executable /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64/bin/lldb --server /Applications/Xcode-9.3.0b1-9Q98q.app/Contents/Developer/../SharedFrameworks/LLDB.framework/Resources/debugserver --test-subdir lang/swift --skip-category=dwo --skip-category=dsym --skip-category=gmodules -G swiftpr -C /Users/mark_lacey/swift-project/build/ra/llvm-macosx-x86_64/bin/clang --results-formatter lldbsuite.test_event.formatter.xunit.XunitFormatter --results-file /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64/test-results/results.xml -O--xpass=success -O--xfail=success
fatal error: category 'swiftpr' is not a valid category
if you have added a new category, please edit test_categories.py, adding your new category to all_categories
else, please specify one or more of the following: ['libc++', 'stresstest', 'dwarf', 'gmodules', 'darwin-log', 'lldb-mi', 'basic_process', 'cmdline', 'objc', 'dataformatters', 'flakey', 'pyapi', 'frame-diagnose', 'watchpoints', 'expression', 'dwo', 'dyntype', 'dsym']
./utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting

[vedantk]

I'll send in a PR to fix the issue with ninja. You'll need to pull from swift-lldb/stable to get a version which has the swiftpr category.

[rudkx]

Awesome, thanks. Trying to build again after updating my lldb repo.

[rudkx]

Okay, now I'm hitting this, but all the rest of the tests pass.

 /usr/bin/python /Users/mark_lacey/swift-project/lldb/test/dotest.py --executable /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64/bin/lldb --server /Applications/Xcode-9.3.0b1-9Q98q.app/Contents/Developer/../SharedFrameworks/LLDB.framework/Resources/debugserver --test-subdir lang/swift --skip-category=dwo --skip-category=dsym --skip-category=gmodules -G swiftpr -C /Users/mark_lacey/swift-project/build/ra/llvm-macosx-x86_64/bin/clang -s 2018-02-02-12_04_47 --results-port 54046 -S fnmac --inferior -p TestSwiftRangeTypes.py /Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/lang/swift --event-add-entries worker_index=2:int
Traceback (most recent call last):
  File "/Users/mark_lacey/swift-project/lldb/test/dotest.py", line 7, in <module>
    lldbsuite.test.run_suite()
  File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1176, in run_suite
    setupTestResults()
  File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 562, in setupTestResults
    formatter_config)
  File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 109, in create_results_formatter
    results_file_object, cleanup_func = create_socket(config.port)
  File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 70, in create_socket
    sock.connect(("localhost", port))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 228, in meth
    return getattr(self._sock,name)(*args)
socket.error: [Errno 61] Connection refused

===================
Test Result Summary
===================
Test Methods:        256
Reruns:                0
Success:              41
Expected Failure:      0
Failure:               1
Error:                 0
Exceptional Exit:      0
Unexpected Success:    0
Skip:                214
Timeout:               0
Expected Timeout:      0

[vedantk]

Oh no :(. Could you file a radar and attach the 2018-02-02-12_04_47 directory? We'd like to make the test harness more reliable.

[vedantk]

@rudkx #300 just updated the test that is failing for you locally. The logs will tell us what kind of test failure this was (either test suite flakiness or a logic error corrected by Ben's patch).

[jimingham]

The code that is failing is doing so because it can't connect to the "results server", which you've specified by the "--results-port option". That's for when you are running a test and there's another agent that wants to receive the tests results on a socket rather than just putting the results in a file. Did you mean to specify a results server? Jim

…

On Feb 2, 2018, at 12:11 PM, Mark Lacey ***@***.***> wrote: Okay, now I'm hitting this, but all the rest of the tests pass. /usr/bin/python /Users/mark_lacey/swift-project/lldb/test/dotest.py --executable /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64/bin/lldb --server /Applications/Xcode-9.3.0b1-9Q98q.app/Contents/Developer/../SharedFrameworks/LLDB.framework/Resources/debugserver --test-subdir lang/swift --skip-category=dwo --skip-category=dsym --skip-category=gmodules -G swiftpr -C /Users/mark_lacey/swift-project/build/ra/llvm-macosx-x86_64/bin/clang -s 2018-02-02-12_04_47 --results-port 54046 -S fnmac --inferior -p TestSwiftRangeTypes.py /Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/lang/swift --event-add-entries worker_index=2:int Traceback (most recent call last): File "/Users/mark_lacey/swift-project/lldb/test/dotest.py", line 7, in <module> lldbsuite.test.run_suite() File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1176, in run_suite setupTestResults() File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 562, in setupTestResults formatter_config) File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 109, in create_results_formatter results_file_object, cleanup_func = create_socket(config.port) File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 70, in create_socket sock.connect(("localhost", port)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 228, in meth return getattr(self._sock,name)(*args) socket.error: [Errno 61] Connection refused =================== Test Result Summary =================== Test Methods: 256 Reruns: 0 Success: 41 Expected Failure: 0 Failure: 1 Error: 0 Exceptional Exit: 0 Unexpected Success: 0 Skip: 214 Timeout: 0 Expected Timeout: 0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jimingham]

I bet this is the multi-threaded runner, and it's one of the test instances trying to send the results of a single test back to the coordinating test-runner. I'll have a look at how it selects the ports to do that communication. If that's right, Mark please do file a bug about this. Jim

…

On Feb 2, 2018, at 12:54 PM, Jim Ingham ***@***.***> wrote: The code that is failing is doing so because it can't connect to the "results server", which you've specified by the "--results-port option". That's for when you are running a test and there's another agent that wants to receive the tests results on a socket rather than just putting the results in a file. Did you mean to specify a results server? Jim > On Feb 2, 2018, at 12:11 PM, Mark Lacey ***@***.***> wrote: > > Okay, now I'm hitting this, but all the rest of the tests pass. > > /usr/bin/python /Users/mark_lacey/swift-project/lldb/test/dotest.py --executable /Users/mark_lacey/swift-project/build/ra/lldb-macosx-x86_64/bin/lldb --server /Applications/Xcode-9.3.0b1-9Q98q.app/Contents/Developer/../SharedFrameworks/LLDB.framework/Resources/debugserver --test-subdir lang/swift --skip-category=dwo --skip-category=dsym --skip-category=gmodules -G swiftpr -C /Users/mark_lacey/swift-project/build/ra/llvm-macosx-x86_64/bin/clang -s 2018-02-02-12_04_47 --results-port 54046 -S fnmac --inferior -p TestSwiftRangeTypes.py /Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/lang/swift --event-add-entries worker_index=2:int > Traceback (most recent call last): > File "/Users/mark_lacey/swift-project/lldb/test/dotest.py", line 7, in <module> > lldbsuite.test.run_suite() > File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1176, in run_suite > setupTestResults() > File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 562, in setupTestResults > formatter_config) > File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 109, in create_results_formatter > results_file_object, cleanup_func = create_socket(config.port) > File "/Users/mark_lacey/swift-project/lldb/packages/Python/lldbsuite/test_event/formatter/__init__.py", line 70, in create_socket > sock.connect(("localhost", port)) > File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 228, in meth > return getattr(self._sock,name)(*args) > socket.error: [Errno 61] Connection refused > > =================== > Test Result Summary > =================== > Test Methods: 256 > Reruns: 0 > Success: 41 > Expected Failure: 0 > Failure: 1 > Error: 0 > Exceptional Exit: 0 > Unexpected Success: 0 > Skip: 214 > Timeout: 0 > Expected Timeout: 0 > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or mute the thread. >

[vedantk]

Mishal has recently enabled smoke testing for lldb PR's. Let's try this again.

[vedantk]

@swift-ci test

[rudkx]

I’m just running with the command-line Vedant suggested so I have no idea what’s going on under the hood, but I can file a bug for it.

[vedantk]

@swift-ci test Linux platform

[vedantk]

The Linux build timed out here too. The change lgtm, I'll go ahead and merge.

[rudkx]

Great, thanks!