-
Notifications
You must be signed in to change notification settings - Fork 50
Fix optional query param parsing #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-server-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for the fix.
@swift-server-bot test this please |
@tib thanks for the review. Have you also had a chance to try this branch to verify the issue is fixed for the cases you tested? |
@swift-server-bot test this please |
Yes, I was able to verify it and the fix works just fine. If you could release this as a patch (0.2.1?) that'd be so nice. Thank you very much for the help. 🙏 |
Will do, just wanted to make sure we really addressed the issue first. Thanks for the confirmation 🙏 |
Motivation
Fixes apple/swift-openapi-generator#249.
Modifications
Adds a
decodeIfPresent
method onURIDecoder
now used by the optional query param getter.Result
This makes the query param getter return nil instead of throwing an error when it encounters a missing optional query param.
Test Plan
Added new unit tests, hopefully these cover it now.