Change type of HTTPBody.Length.known from Int to Int64 #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@czechboy0 we discussed previously on the Github issue renaming this to |
|
No let's just change the type, no need to stage this in. We'll be making more breaking changes before 1.0.0-alpha.1 anyway. |
czechboy0
approved these changes
Nov 27, 2023
|
OK, merging over API breakage CI as this is a deliberate API break, and the PR is labelled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The associated value of enum case
HTTPBody.Length.knownwasInt, and, on watchOS,Int = Int32, which is not ideal for a content length.Modifications
Result
Can now express larger values for content type on 32-bit platforms.
Test Plan
Unit tests pass.
Related Issues
Note
I have marked this PR as
semver/majoras it constitutes the first of the PRs we make in the run up to 1.0.0-alpha.1 and the release notes generator should therefore catch us from inadvertently cutting another pre-1.0 patch release.