Code cleanup; FilePath separator normalization #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemacomber
approved these changes
Nov 16, 2020
| // The platform preferred separator | ||
| // | ||
| // TODO: Make private | ||
| private var platformSeparator: SystemChar { |
There was a problem hiding this comment.
Since this is private I think you can remove the TODO.
| extension FilePath { | ||
| // For invariant enforcing/checking. Should always return `nil` on | ||
| // a fully-formed path | ||
| private func _trailingSepIdx() -> Storage.Index? { |
There was a problem hiding this comment.
Suggested change
| private func _trailingSepIdx() -> Storage.Index? { | |
| private func _trailingSeparatorIndex() -> Storage.Index? { |
The abbreviation here seems ad hoc.
Co-authored-by: Kyle Macomber <[email protected]>
Co-authored-by: Kyle Macomber <[email protected]>
Co-authored-by: Kyle Macomber <[email protected]>
|
Closing this, FIlePath syntactic operations has diverged significantly. I could consider doing some of the refactoring in a separate PR, though it might make more sense to just do it as a rebasing on that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting off some of the work being done in #14. This brings in the separator normalizing behavior as well as re-arranging some of the source code.