Add support for WASILibc module
#159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly amounted to excluding unsupported errnos, adding TLS dictionary storage shim for single-threaded environment, and adding constants in C headers for macros that Clang importer currently doesn't support.
|
@swift-ci test |
|
Adding CI jobs for WASI is currently blocked by swiftlang/swift#72728. |
|
@swift-ci test |
|
@swift-ci test |
kateinoigakukun
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Locally tested and it works well 👍
$ cat Sources/main.swift
import SystemPackage
let message: String = "Hello, world!" + "\n"
let path: FilePath = "/tmp/log"
let fd = try FileDescriptor.open(
path, .writeOnly, options: [.append, .create], permissions: .ownerReadWrite)
try fd.closeAfter {
_ = try fd.writeAll(message.utf8)
}
$ swift build --experimental-swift-sdk DEVELOPMENT-SNAPSHOT-2024-04-25-a-wasm32-unknown-wasi
$ wasmtime --dir /tmp .build/debug/Example.wasm
$ cat /tmp/log
Hello, world!
glessard
reviewed
Apr 30, 2024
Co-authored-by: Guillaume Lessard <[email protected]>
glessard
reviewed
Apr 30, 2024
|
@swift-ci please test |
|
@glessard Yes, we have multi-threaded wasi target as a separate triple (wasm32-unknown-wasip1-threads) from the non-threaded one (wasm32-unknown-wasi) |
Yes, but that requires a special Swift SDK to be installed from artifacts built by the SwiftWasm org. There's ongoing work to build that on Swift CI directly in swiftlang/swift#72728. |
glessard
pushed a commit
to glessard/swift-system
that referenced
this pull request
Oct 17, 2024
Quoting the [wasi.dev landing page](https://wasi.dev): > The WebAssembly System Interface (WASI) is a group of standard API specifications for software compiled to the W3C WebAssembly (Wasm) standard. WASI is designed to provide a secure standard interface for applications that can be compiled to Wasm from any language, and that may run anywhere—from browsers to clouds to embedded devices. Currently support for WASI in Swift is based on [`wasi-libc`](https://github.com/WebAssembly/wasi-libc). Adding support for `wasi-libc` mostly amounted to excluding unsupported errnos, adding TLS dictionary storage shim for single-threaded environment, and adding constants in C headers for macros that Clang importer currently doesn't support. Co-authored-by: Guillaume Lessard <[email protected]> # Conflicts: # Sources/System/FileOperations.swift # Sources/System/Internals/Syscalls.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting the wasi.dev landing page:
Currently support for WASI in Swift is based on
wasi-libc.Adding support for
wasi-libcmostly amounted to excluding unsupported errnos, adding TLS dictionary storage shim for single-threaded environment, and adding constants in C headers for macros that Clang importer currently doesn't support.