Fix SSL Verification in Python SDK #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the SDKs verify SSL certificates by default except for the Python SDK due to a but in the logic for SSL verification. This change fixes the logic to ensure SSL verification is done by default.
Closes: appwrite/sdk-for-python#40
Before the update, SSL verification isn't done and there is a warning that SSL verification isn't done. The following screenshot shows the warning as well as the request continuing to https://dne.appwrite.io/v1 (which results in HTTP Status 400 as expected).
After the update, SSL verification is done and the request is not sent due to the SSL handshake failure: