Skip to content

Fix SSL Verification in Python SDK #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

stnguyen90
Copy link
Contributor

All the SDKs verify SSL certificates by default except for the Python SDK due to a but in the logic for SSL verification. This change fixes the logic to ensure SSL verification is done by default.

Closes: appwrite/sdk-for-python#40

Before the update, SSL verification isn't done and there is a warning that SSL verification isn't done. The following screenshot shows the warning as well as the request continuing to https://dne.appwrite.io/v1 (which results in HTTP Status 400 as expected).

Python SDK SSL Warning

After the update, SSL verification is done and the request is not sent due to the SSL handshake failure:

Python SDK Error

@stnguyen90
Copy link
Contributor Author

The Travis CI build error looks like the same error I experienced over in #270. Should I apply the same fix in this PR?

@TorstenDittmann
Copy link
Contributor

The Travis CI build error looks like the same error I experienced over in #270. Should I apply the same fix in this PR?

We fixed the CI on master, please get in sync with it and the tests should run again 🙏🏻

All the SDKs verify SSL certificates by default except for
the Python SDK due to a but in the logic for SSL verification.
This change fixes the logic to ensure SSL verification is
done by default.
@stnguyen90 stnguyen90 force-pushed the fix-40-fix-python-ssl branch from 2813048 to da9f3c7 Compare October 16, 2021 02:25
@stnguyen90
Copy link
Contributor Author

The Travis CI build error looks like the same error I experienced over in #270. Should I apply the same fix in this PR?

We fixed the CI on master, please get in sync with it and the tests should run again 🙏🏻

I rebased and the build is now passing.

@eldadfux eldadfux merged commit 2ba79d7 into appwrite:master Oct 17, 2021
@eldadfux
Copy link
Member

THANK YOU! All changes merged 🥳

Please reach out to me (eldadfux) on our Discord server if you would like to claim your Appwrite swags!

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues to help make Appwrite better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL Verification is Off by Default
3 participants