Update build.gradle #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dependencies compile for implementation
|
@aprock or @phillbaker |
|
Thanks for the PR. Can you clarify the problem you’re trying to solve?
I'm not sure that this change is necessary as the typical outputs in
Android studio are only deprecation warnings, not errors. This change is
usually a suggestion, not a requirement. I believe that changing this would
also break backward compatibility with other versions of gradle.
…On Fri, Aug 23, 2019 at 5:56 PM Juan Pablo Moreno Rico < ***@***.***> wrote:
@aprock <https://github.com/aprock> or @phillbaker
<https://github.com/phillbaker>
Hope you can merge this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AAAXCKNKHFXFO7RIHWR3ICLQGBMJNA5CNFSM4IPDUZT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BNTWA#issuecomment-524474840>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAXCKNVJZPDZRRJLPJIKVTQGBMJNANCNFSM4IPDUZTQ>
.
|
|
ok no |
This was referenced Sep 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change dependencies compile for implementation