ci: add Trivy 0.57.1 and 0.58.1 to bundle testing #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Jan 14, 2025
| @@ -16,7 +16,7 @@ import ( | |||
|
|
|||
| var bundlePath = "bundle.tar.gz" | |||
| var OrasPush = []string{"--artifact-type", "application/vnd.cncf.openpolicyagent.config.v1+json", fmt.Sprintf("%s:application/vnd.cncf.openpolicyagent.layer.v1.tar+gzip", bundlePath)} | |||
| var supportedTrivyVersions = []string{"latest", "canary"} // TODO: add more versions | |||
| var supportedTrivyVersions = []string{"0.57.1", "0.58.1", "latest", "canary"} // TODO: add more versions | |||
There was a problem hiding this comment.
Any reason why we should add these two versions in particular?
There was a problem hiding this comment.
I thought we should use some older versions for backwards compatibility testing, instead of using only the latest ones. I chose some versions starting with 0.57.1 as this is the first version of Trivy where we added bundle v1 support.
There was a problem hiding this comment.
OK let's go ahead with this for now. I wonder if it's worth making this list dynamic in the next iteration of improving this test.
Signed-off-by: Nikita Pivkin <[email protected]>
simar7
force-pushed
the
trivy-bundle-v
branch
from
8a130fa to
bd310fd
Compare
simar7
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.