fix(misconf): do not log scanners when misconfig scanning is disabled #8345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Do we need this even when the misconfiguration scanner is disabled?
trivy/pkg/commands/artifact/run.go
Lines 437 to 444 in 6826601
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
force-pushed
the
fix/misconf-log-scanners
branch
from
6826601 to
af4379f
Compare
|
Fixed af4379f |
knqyf263
approved these changes
Feb 4, 2025
DmitriyLewen
reviewed
Feb 4, 2025
pkg/commands/artifact/run.go
Outdated
| } | ||
|
|
||
| log.Debug("Enabling misconfiguration scanners", | ||
| log.Any("scanners", lo.Without(analyzer.TypeConfigFiles, analyzers...))) |
There was a problem hiding this comment.
IIUC we don't need to check all analyzers here.
Suggested change
| log.Any("scanners", lo.Without(analyzer.TypeConfigFiles, analyzers...))) | |
| log.Any("scanners", lo.Without(analyzer.TypeConfigFiles, ma...))) |
pkg/commands/artifact/run.go
Outdated
| // Do not perform misconfiguration scanning when it is not specified. | ||
| if !opts.Scanners.AnyEnabled(types.MisconfigScanner, types.RBACScanner) { | ||
| analyzers = append(analyzers, analyzer.TypeConfigFiles...) | ||
| } else { | ||
| // Filter only enabled misconfiguration scanners | ||
| ma, err := disabledMisconfigAnalyzers(analyzer.TypeConfigFiles, opts.MisconfigScanners) |
There was a problem hiding this comment.
nit:
is there any point in passing analyzer.TypeConfigFiles as an argument to the function?
Signed-off-by: nikpivkin <[email protected]>
DmitriyLewen
approved these changes
Feb 4, 2025
|
@aqua-bot backport release/v0.59 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…#8345) Signed-off-by: nikpivkin <[email protected]>
|
Backport PR created: #8349 |
RingoDev
pushed a commit
to RingoDev/trivy
that referenced
this pull request
Feb 26, 2025
…aquasecurity#8345) Signed-off-by: nikpivkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR logs enabled misconfiguration scanners only when misconfig scanning is enabled.
Checklist