recent omxplayer build break #229
Comments
|
ah, yeah omxplayer videoplayer defaults to off now that's why I didn't catch it. (If you can, use the gstreamer video player instead)
|
|
though maybe it's better to make it default to on again, so people don't get breakages |
|
@ardera that fixed it. Thanks for the quick fix |
|
@ardera I updated recipe to default to gstreamer. CI jobs are all passing, and images are available for test. I suspect there will be some runtime deps missing. Do you have a sample app to validate this with? |
|
@jwinarske The gstreamer video player shouldn't have any additional runtime dependencies, though I made it a soft-error if some dependencies for the gstreamer player couldn't be found while configuring, so people don't get build breakages. (It'll print a message in that case) The new gstreamer video player just implements the default platform interface of the official import 'package:video_player/video_player.dart';
import 'package:flutter/material.dart';
void main() => runApp(VideoApp());
class VideoApp extends StatefulWidget {
@override
_VideoAppState createState() => _VideoAppState();
}
class _VideoAppState extends State<VideoApp> {
VideoPlayerController _controller;
@override
void initState() {
super.initState();
_controller = VideoPlayerController.network(
'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4')
..initialize().then((_) {
// Ensure the first frame is shown after the video is initialized, even before the play button has been pressed.
setState(() {});
});
}
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Video Demo',
home: Scaffold(
body: Center(
child: _controller.value.isInitialized
? AspectRatio(
aspectRatio: _controller.value.aspectRatio,
child: VideoPlayer(_controller),
)
: Container(),
),
floatingActionButton: FloatingActionButton(
onPressed: () {
setState(() {
_controller.value.isPlaying
? _controller.pause()
: _controller.play();
});
},
child: Icon(
_controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
),
),
),
);
}
@override
void dispose() {
super.dispose();
_controller.dispose();
}
} |
Turns out I forgot to push that part. It's working now, |
Picked up this build break since your last set of changes. I was pulling tip of tree, but now I'm considering on snapping to a commit.
I have disabled omxplayer in flutter-pi recipe for now.
The text was updated successfully, but these errors were encountered: