Skip to content

Fallback to gbm_surface_create if gbm_surface_create_with_modifiers does not work #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ardera opened this issue Jul 25, 2022 · 1 comment · Fixed by #270
Closed

Fallback to gbm_surface_create if gbm_surface_create_with_modifiers does not work #269

ardera opened this issue Jul 25, 2022 · 1 comment · Fixed by #270

Comments

@ardera
Copy link
Owner

ardera commented Jul 25, 2022

Seems like the proprietary mali driver does not support gbm_surface_create_with_modifiers.
@bojidartonchev bojidartonchev mentioned this issue Jul 25, 2022
Merged
@bojidartonchev
Copy link
Contributor

Implemented it in my fork. Now it is working just fine. Created a pull request for that.

@bojidartonchev bojidartonchev mentioned this issue Jul 25, 2022
Closed
ardera pushed a commit that referenced this issue Aug 9, 2022
@bojidartonchev
fallback to gbm_surface_create if gbm_surface_create_with_modifiers d…
869fa7f 
…oes not work (#270)

- implements #269 
- some drivers don't support `gbm_bo_create_with_modifiers` in that case `gbm_bo_create` is used now.
- the `GBM_BO_USE_*` flags are a bit restrictive right now, in the future we might be able to drop `GBM_BO_USE_LINEAR`.
@ardera ardera linked a pull request Aug 11, 2022 that will close this issue
Fallback to gbm_surface_create if gbm_surface_create_with_modifiers does not work #270
Merged
@ardera ardera closed this as completed Aug 11, 2022
@yann-morin-1998 yann-morin-1998 mentioned this issue Sep 29, 2023
Merged
ardera pushed a commit that referenced this issue Oct 11, 2023
@yann-morin-1998 @ardera
src/egl_gbm_render_surface: properly fallback to surface with no modi…
9fde680 
…fier

In 869fa7f, we added a fallback to be able to create an EGL sruface
when the driver do not support modifiers, like the llvmpipe software
renderer (or like some proprietary drivers, like the MALI ones), as
reported in #269 [0].

However, in c653767, there was a big overhaul of renderer
infrastructure. That commit lost the with-modifiers code path and only
kept the without-modifiers fallback one (i.e. it only kept the call to
gbm_surface_create(), not to gbm_surface_create_with_modifiers()).

Then in b0d09f5, the with-modifier code path was re-instated, but
in a way that made it exclusive with the without-modifiers one. That is,
the without-modifiers code path was not a fallback to when the other
failed.

Re-instate the fallback mechanism as initially implemented.

[0] #269

Signed-off-by: Yann E. MORIN <[email protected]>
@beniskopf beniskopf mentioned this issue Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ardera @bojidartonchev