Skip to content

Implement vsync #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ardera opened this issue Oct 21, 2019 · 1 comment · Fixed by #70
Closed

Implement vsync #8

ardera opened this issue Oct 21, 2019 · 1 comment · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@ardera
Copy link
Owner

ardera commented Oct 21, 2019

Currently, flutter-pi runs without vsync, which results in visible tearing. In the future, there should be vsync support, but I first have to figure out how to do this.
There are multiple ways you can implement vsync:

  • you can use the legacy (?) drm way using page-flips
  • or use the atomic way, native fence etc.

I have no idea which is better (in terms of performance, compatibility, etc). Compatibility would be nice to have, since this embedder may support other platforms than raspberry pi in the future.

@ardera ardera self-assigned this Oct 21, 2019
@ardera ardera added the enhancement New feature or request label Oct 21, 2019
@ardera
Copy link
Owner Author

ardera commented Feb 3, 2020

Implemented in #24, although I'm not sure it's fully working.

Tearing is definitely a lot better than before, but it seems sometimes it still occurrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant