Skip to content

Implement AOT #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Implement AOT #68

merged 1 commit into from
Aug 1, 2020

Conversation

DisDis
Copy link
Contributor

@DisDis DisDis commented Jul 30, 2020

No description provided.

@DisDis DisDis mentioned this pull request Jul 30, 2020
@ardera
Copy link
Owner

ardera commented Aug 1, 2020

Thanks for your contribution @DisDis !
I'll actually merge my own version of AOT support (plus some refactors, fixes, additions) soon
I'll merge this PR anyway so people can enjoy AOT in the meantime

@ardera ardera merged commit 052077b into ardera:master Aug 1, 2020
@DisDis DisDis deleted the aot branch August 1, 2020 22:49
@GioPan04
Copy link

GioPan04 commented Aug 3, 2020

So, now how we can try the AOT mode?

@DisDis
Copy link
Contributor Author

DisDis commented Aug 3, 2020

So, now how we can try the AOT mode?

1.Build release engine(only dev channel, currently)
2.Instruction for libapp.so: #65 (comment)
3. flutter-pi -a ./libapp.so ./assets

@GioPan04
Copy link

GioPan04 commented Aug 3, 2020

So, now how we can try the AOT mode?

1.Build release engine(only dev channel, currently)
2.Instruction for libapp.so: #65 (comment)
3. flutter-pi -a ./libapp.so ./assets

How can I build the release engine? Can you link me a doc or something? The only doc I found is this: https://github.com/flutter/flutter/wiki/Compiling-the-engine#compiling-for-macos-or-linux
Is this the right one?

@GioPan04
Copy link

GioPan04 commented Aug 3, 2020

Okay jk, i found your comment where you explain how to build the engine https://github.com/ardera/flutter-pi/issues/65#issuecomment-665694767

@ardera
Copy link
Owner

ardera commented Aug 4, 2020

@DisDis I just realized, since you're using the dev channel anyway, you can just rely on FlutterEngineCreateAOTData and FlutterEngineCollectAOTData to load and destroy the AOT data, instead of doing it manually

@DisDis
Copy link
Contributor Author

DisDis commented Aug 4, 2020

@ardera
What are these methods used for?
I have not researched flutter in this direction.

@ardera
Copy link
Owner

ardera commented Aug 4, 2020

You invoke FlutterEngineCreateAOTData with the path to the libapp.so and it does all the loading for you
These API calls are not present on the stable channel, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants